dcerpc: TCPTransport.recv: break on empty recv to avoid infinite loop #2061
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, any updates about this one? |
Collaborator
|
Hello, thanks for reporting the issue! Regarding changes, I would say it's ok, but returning from recv in the middle of an error condition wouldn't be the best. That would end up in another infinite loop in impacket/impacket/dcerpc/v5/rpcrt.py Line 1875 in 7bd0d5a So, is there any specific scenario that you were able to replicate the issue? I'm curious about this, besides the fact that a connection should be close in the middle of receiving data, how this condition could be triggered through a high level use case. |
anadrianmanrique
added
the
waiting for response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the peer closes the connection, socket.recv() returns b''.
The previous loop made no progress and could spin forever.
Break on empty chunk to avoid the infinite loop.